Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for late-bound vars from parent arg-position impl trait #113071

Merged

Conversation

compiler-errors
Copy link
Member

We should be reporting an error like we do for late-bound args coming from a parent APIT.

Fixes #113016

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 26, 2023
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
@rust-cloud-vms rust-cloud-vms bot force-pushed the no-parent-non-lifetime-args-in-apit branch from 2a74d7c to 724f3ff Compare June 26, 2023 19:15
type Assoc;
}

fn uwu(_: impl for<T> Trait<(), Assoc = impl Trait<T>>) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't even know for<T> was a thing!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eholk
Copy link
Contributor

eholk commented Jun 29, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 29, 2023

📌 Commit 724f3ff has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2023
@compiler-errors
Copy link
Member Author

@bors rollup

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 30, 2023
…time-args-in-apit, r=eholk

Account for late-bound vars from parent arg-position impl trait

We should be reporting an error like we do for late-bound args coming from a parent APIT.

Fixes rust-lang#113016
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107624 (Stabilize `const_cstr_methods`)
 - rust-lang#111403 (suggest `slice::swap` for `mem::swap(&mut x[0], &mut x[1])` borrowck error)
 - rust-lang#113071 (Account for late-bound vars from parent arg-position impl trait)
 - rust-lang#113165 (Encode item bounds for `DefKind::ImplTraitPlaceholder`)
 - rust-lang#113171 (Properly implement variances_of for RPITIT GAT)
 - rust-lang#113177 (Use structured suggestion when telling user about `for<'a>`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0b96b25 into rust-lang:master Jun 30, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 30, 2023
@compiler-errors compiler-errors deleted the no-parent-non-lifetime-args-in-apit branch August 11, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: unexpected bound var resolution for HirId(DefId(
5 participants